Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA yocto workflows for common device types #3456

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

klutchell
Copy link
Collaborator

These workflows are for testing the build steps only.

Change-type: patch


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@klutchell klutchell temporarily deployed to balena-staging.com July 6, 2024 14:16 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com July 6, 2024 14:16 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com July 6, 2024 14:16 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com July 6, 2024 14:16 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to bm.balena-dev.com July 6, 2024 14:53 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to bm.balena-dev.com July 6, 2024 14:53 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to bm.balena-dev.com July 6, 2024 14:53 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to bm.balena-dev.com July 6, 2024 14:54 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to bm.balena-dev.com July 6, 2024 14:54 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to bm.balena-dev.com July 6, 2024 14:54 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to bm.balena-dev.com July 6, 2024 15:05 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to bm.balena-dev.com July 6, 2024 15:05 — with GitHub Actions Inactive
These workflows are for testing the build steps only.

Change-type: patch
Signed-off-by: Kyle Harding <[email protected]>
@klutchell klutchell temporarily deployed to bm.balena-dev.com July 7, 2024 19:35 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to bm.balena-dev.com July 7, 2024 19:52 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to bm.balena-dev.com July 7, 2024 19:52 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to bm.balena-dev.com July 7, 2024 19:52 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to bm.balena-dev.com July 7, 2024 19:54 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to bm.balena-dev.com July 7, 2024 19:54 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to bm.balena-dev.com July 7, 2024 19:54 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com July 10, 2024 14:56 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com July 10, 2024 14:56 — with GitHub Actions Inactive
@klutchell klutchell marked this pull request as ready for review July 10, 2024 14:57
Copy link
Member

@vipulgupta2048 vipulgupta2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the benefit of doing genericx86-64 and intel-nuc here on meta-balena again? Are we completing the checklist or actually testing new functionality

@klutchell
Copy link
Collaborator Author

What's the benefit of doing genericx86-64 and intel-nuc here on meta-balena again? Are we completing the checklist or actually testing new functionality

Just completing the checklist, I don't expect to discover any new issues here except we can test without deploys on this repo.

Copy link
Contributor

@lmbarros lmbarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Small differences from what I was using on my fork (no deploys, use "this" meta-balena branch), all of which seem to make sense for meta-balena testing.

@klutchell klutchell merged commit 9de895f into master Jul 10, 2024
75 checks passed
@klutchell klutchell deleted the kyle/gha-workflow branch July 10, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants