Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker API version in recipes to match balena API version #3438

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

alexgg
Copy link
Contributor

@alexgg alexgg commented Jun 3, 2024


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@alexgg alexgg force-pushed the alexgg/apiversion branch 3 times, most recently from 849fd72 to 8de8f68 Compare June 13, 2024 10:11
@klutchell
Copy link
Collaborator

I tried building generic-amd64 against this PR and got an error:

ERROR: mkfs-hostapp-native-1.0-r0 do_compile: ExecutionError('/work/build/tmp/work/x86_64-linux/mkfs-hostapp-native/1.0-r0/temp/run.do_compile.29324', 1, None, None)
ERROR: Logfile of failure stored in: /work/build/tmp/work/x86_64-linux/mkfs-hostapp-native/1.0-r0/temp/log.do_compile.29324
Log data follows:
| DEBUG: Executing shell function do_compile
| Sending build context to Docker daemon   5.12kB
| 
| Error response from daemon: client version 1.41 is too new. Maximum supported API version is 1.40
| WARNING: exit code 1 from a shell command.

@alexgg
Copy link
Contributor Author

alexgg commented Jun 14, 2024

I tried building generic-amd64 against this PR and got an error:

ERROR: mkfs-hostapp-native-1.0-r0 do_compile: ExecutionError('/work/build/tmp/work/x86_64-linux/mkfs-hostapp-native/1.0-r0/temp/run.do_compile.29324', 1, None, None)
ERROR: Logfile of failure stored in: /work/build/tmp/work/x86_64-linux/mkfs-hostapp-native/1.0-r0/temp/log.do_compile.29324
Log data follows:
| DEBUG: Executing shell function do_compile
| Sending build context to Docker daemon   5.12kB
| 
| Error response from daemon: client version 1.41 is too new. Maximum supported API version is 1.40
| WARNING: exit code 1 from a shell command.

We could reduce the API version to increase the compatibility with docker hosts, or enforce that the minimum version of a docker installed in the host needs to match the balenaEngine version.

Was this a native build @klutchell or a builder instance?

@klutchell
Copy link
Collaborator

klutchell commented Jun 14, 2024

Was this a native build or a builder instance?

@alexgg this was on our GitHub runners, using the balena-build.sh helper image. I would expect anyone using the helper image to see the same error, including Jenkins?

Since the helper image provides a DinD I assume we can just bump the version of Docker in there to remain aligned? I've already been considering the bump from Ubuntu 18 to 20 for that image being that 18 is EOL.

As you say we can recommend that users not using the helper image should update their host Docker version.

@alexgg
Copy link
Contributor Author

alexgg commented Jun 24, 2024

@resin-jenkins retest this please

@alexgg
Copy link
Contributor Author

alexgg commented Jun 24, 2024

The helper images has been updated to 22.04.

@alexgg
Copy link
Contributor Author

alexgg commented Jun 26, 2024

Pending on device repositories to update balena-yocto-scripts.

@alexgg alexgg force-pushed the alexgg/apiversion branch 3 times, most recently from 37490f9 to 2a23a94 Compare July 6, 2024 10:52
@alexgg
Copy link
Contributor Author

alexgg commented Jul 6, 2024

Requires balena-os/balena-up-board#612

@alexgg alexgg force-pushed the alexgg/apiversion branch 2 times, most recently from 654bfbe to 3e91ac8 Compare July 12, 2024 09:00
@alexgg alexgg temporarily deployed to balena-staging.com July 12, 2024 09:00 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com July 12, 2024 09:00 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com July 12, 2024 09:00 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com July 12, 2024 09:00 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to bm.balena-dev.com July 12, 2024 09:33 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to bm.balena-dev.com July 12, 2024 09:33 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to bm.balena-dev.com July 12, 2024 09:33 — with GitHub Actions Inactive
Copy link

github-actions bot commented Jul 17, 2024

Website deployed to CF Pages, 👀 preview link https://65596ea5.balena-os.pages.dev

This is used to match the API version used in the build pipeline with
the balena version used in the image.

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
Update the API version to the version set in the distro configuration,
which must match the API version of the balena package.

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
@alexgg alexgg temporarily deployed to balena-cloud.com July 22, 2024 08:18 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-cloud.com July 22, 2024 08:18 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-cloud.com July 22, 2024 08:18 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-cloud.com July 22, 2024 08:18 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-cloud.com July 22, 2024 08:18 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-cloud.com July 22, 2024 08:18 — with GitHub Actions Inactive
@flowzone-app flowzone-app bot merged commit 4e30b67 into master Jul 22, 2024
62 of 63 checks passed
@flowzone-app flowzone-app bot deleted the alexgg/apiversion branch July 22, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants