Patch: switch from node-ipc to ws #4185
Conversation
|
Looks great overall @aethernet. Iterate on this as much as you need and merge at will. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aethernet
force-pushed
the
reverse-control-flow
branch
5 times, most recently
from
36cbcd9
to
bab630f
Compare
aethernet
force-pushed
the
reverse-control-flow
branch
6 times, most recently
from
1e97f88
to
15e47ed
Compare
aethernet
force-pushed
the
reverse-control-flow
branch
2 times, most recently
from
5e2dfac
to
2d594f6
Compare
|
A little rough on the edge, but should be good to go for a pre-release test |
aethernet
force-pushed
the
reverse-control-flow
branch
from
2d594f6
to
8e27a0d
Compare
aethernet
force-pushed
the
reverse-control-flow
branch
from
8e27a0d
to
9e540b9
Compare
aethernet
force-pushed
the
reverse-control-flow
branch
from
9e540b9
to
0a3b483
Compare
aethernet
force-pushed
the
reverse-control-flow
branch
3 times, most recently
from
0aeb805
to
f439ee1
Compare
| } | ||
|
|
||
| /** | ||
| * @summary Handle `errors` |
There was a problem hiding this comment.
All these doc strings don’t seem to add much besides noise. Delete them? Unless you feel like there’s subtleties in each function that you need to surface as a comment, in which case by all means do so.
There was a problem hiding this comment.
I have a tendency to over-comment. It's like using your turn signal in the middle of the night, all alone on the highway; it doesn't do anything, but it's a reflex, and I prefer to do it when it's not needed rather than risk not doing it when it would be necessary.
There was a problem hiding this comment.
But I'm happy to remove them if you feel strongly about it :)
There was a problem hiding this comment.
I’m not offended to see them, but if optimizing for readability is a worthy goal then comments that don’t offer valuable information have no place in the code base because they contribute to noise.
aethernet
force-pushed
the
reverse-control-flow
branch
from
5bc89db
to
67c7a6c
Compare
- switch api roles flow - use websocket instead of node-ipc - integrate; modernize; simplify and deprecate sudo-prompt
aethernet
force-pushed
the
reverse-control-flow
branch
from
67c7a6c
to
ccc31bb
Compare
This PR does 2 things (on top )
node-ipctowsThis makes debugging the flasher way easier and further decouple the flasher and gui, which open up the road to a standalone flasher and other cool features.