Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Products are not visible on Shop if tax inclusive is enabled. #8659

Closed
1 task done
Amitk-webkul opened this issue Oct 12, 2023 · 1 comment
Closed
1 task done

Products are not visible on Shop if tax inclusive is enabled. #8659

Amitk-webkul opened this issue Oct 12, 2023 · 1 comment
Labels
2.x 2.x Versions Bug Fixed When bug issue is fixed. Bug Something isn't working. Hacktoberfest Bagisto Hacktoberfest Event.

Comments

@Amitk-webkul
Copy link
Contributor

Amitk-webkul commented Oct 12, 2023 •
edited
Loading

Terms

  • Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected

master

Issue Description

Products are not visible if tax is enabled.

Preconditions

  1. Admin should be logged in.
  2. Admin should have a tax.
  3. Admin should have enabled Tax inclusive.
  4. Admin should have at least one product created.

Steps to reproduce

  1. Go to 'Shop'
  2. Scroll down to 'Products carousel/ categories'
  3. See the error

Expected Result

It should be shown the products in the listing/carousel on Shop.

Actual Result

Continue loading and not able to view products. Here

Screenshots

No response

Additional context

No response
@Amitk-webkul Amitk-webkul added Bug Something isn't working. Hacktoberfest Bagisto Hacktoberfest Event. 2.x 2.x Versions labels Oct 12, 2023
@Amitk-webkul Amitk-webkul changed the title Products are not visible if tax is enabled. Products are not visible on Shop if tax is enabled. Oct 12, 2023
@Amitk-webkul Amitk-webkul changed the title Products are not visible on Shop if tax is enabled. Products are not visible on Shop if tax inclusive is enabled. Oct 12, 2023
@shivendra-webkul shivendra-webkul mentioned this issue Oct 12, 2023
Merged
@shivendra-webkul shivendra-webkul added Bug Fixed When bug issue is fixed. and removed Bug Fixed When bug issue is fixed. labels Oct 12, 2023
jitendra-webkul added a commit that referenced this issue Oct 16, 2023
@jitendra-webkul
Merge pull request #8662 from shivendra-webkul/issue_8659
9de475d 
fixed issue #8659
@Amitk-webkul
Copy link
Contributor Author

Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x 2.x Versions Bug Fixed When bug issue is fixed. Bug Something isn't working. Hacktoberfest Bagisto Hacktoberfest Event.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Amitk-webkul @shivendra-webkul