Skip to content

Commit

Permalink
Disable Jack logging by default
Browse files Browse the repository at this point in the history
Jack sometimes outputs a log of messages and AIXLOG is not thread-safe
at the moment, so enabling Jack logging leads to quite a few missing
log messages or messages with invalid log-level or tag.
  • Loading branch information
mawe42 authored and badaix committed Jun 19, 2024
1 parent 3527c0a commit 2f6648c
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions server/streamreader/jack_stream.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,13 @@ JackStream::JackStream(PcmStream::Listener* pcmListener, boost::asio::io_context
throw SnapException("JackStreams only support 16, 24 and 32 bit sample formats");
}

#if 0
// Disabled by default as aixlog <= 1.4.0 is not thread-safe at the moment
// and Jack produces quite a few log message.
// TODO: enable if and when aixlog becomes thread-safe.
jack_set_error_function([](const char* msg) { LOG(ERROR, LOG_TAG) << "Jack Error: " << msg << "\n"; });
jack_set_info_function([](const char* msg) { LOG(DEBUG, LOG_TAG) << msg << "\n"; });
#endif
}


Expand Down

0 comments on commit 2f6648c

Please sign in to comment.