Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Syncthing to the Helm chart #308

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Conversation

JohnStrunk
Copy link
Member

Describe what this PR does

  • Adds Syncthing to the Helm chart so that its images can be customized like the other movers
  • Updates the GH workflow to properly load the ST image under test instead of :latest

Is there anything that requires special attention?

Related issues:

@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

@JohnStrunk
Copy link
Member Author

/cc @RobotSail

@openshift-ci openshift-ci bot requested a review from RobotSail July 7, 2022 18:18
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2022

@JohnStrunk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift 9bce9cd link false /test e2e-openshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk, RobotSail

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 0366ab2 into backube:main Jul 7, 2022
@JohnStrunk JohnStrunk deleted the st-helm branch July 8, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants