Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable periodic builds of release branches #307

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

JohnStrunk
Copy link
Member

@JohnStrunk JohnStrunk commented Jul 7, 2022

Describe what this PR does

  • Enable triggering docs and operator flows manually. This is needed for upcoming scheduled builds
  • Consolidate the container push jobs and turn them into a re-usable action to cut down on code duplication

Is there anything that requires special attention?

  • The "Periodic" job isn't triggering the release-* branches yet because this PR needs to be backported to release-0.4 so that "workflow_dispatch" is enabled for the operator and documentation workflows on that branch. Once that is done, the 2 lines in periodic can be uncommented.

Related issues:
Fixes #266

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

- Enable triggering docs and operator flows manually. This is needed for
  upcoming scheduled builds
- Consolidate the container push jobs and turn them into a re-usable
  action to cut down on code duplication

Signed-off-by: John Strunk <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #307 (692ffeb) into main (c43b146) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main    #307     +/-   ##
=======================================
- Coverage   64.0%   64.0%   -0.1%     
=======================================
  Files         43      43             
  Lines       5056    5056             
=======================================
- Hits        3239    3236      -3     
- Misses      1623    1626      +3     
  Partials     194     194             
Impacted Files Coverage Δ
controllers/mover/syncthing/mover.go 79.4% <0.0%> (-0.6%) ⬇️

@JohnStrunk JohnStrunk marked this pull request as ready for review July 8, 2022 13:16
@JohnStrunk
Copy link
Member Author

/cc @tesshuflower
There's a lot of change to the workflows here. I did my best to test things in a separate repo, but it's still 🤞

@openshift-ci openshift-ci bot requested a review from tesshuflower July 8, 2022 13:19
@JohnStrunk
Copy link
Member Author

/retest
Due to #309

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

@JohnStrunk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift 692ffeb link false /test e2e-openshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@tesshuflower tesshuflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JohnStrunk,tesshuflower]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Scheduled runs for release branches
2 participants