feat: add modules option toggle #2738
Conversation
✅ Deploy Preview for babel ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
js/repl/ReplOptions.tsx
Outdated
| onChange={this._onEnvPresetSettingChange("modules")} | ||
| disabled={!envConfig.isEnvPresetEnabled} | ||
| > | ||
| <option value="auto">auto</option> |
There was a problem hiding this comment.
I think we shouldn't support "auto" in the REPL, since in this specific case it's just a synonymous for "commonjs" and there is now way just using the REPL to see how "auto" actually behaves.
And maybe we could default to ESM?
There was a problem hiding this comment.
As a follow up, I'd like to make ESM imports of URLs work in the REPL, so that people can load external deps.
There was a problem hiding this comment.
As a follow up, I'd like to make ESM imports of URLs work in the REPL, so that people can load external deps.
Do you mean allow the import to execute?
There was a problem hiding this comment.
Yes, when you enable evaluate in the sidebar.
There was a problem hiding this comment.
Something like this: bloomberg/record-tuple-polyfill#30
There was a problem hiding this comment.
Looks great, I tried doing this with rollup, but only partially.
Added
modulesoption toggle to REPL, also updated REPL docs links.Preview link: https://deploy-preview-2738--babel.netlify.app/repl