ci: downgrade xunit to 2.4.2 since xunit.runners.visualstudio that ha…

…s support for net5 and older
bUnit-dev · Sep 5, 2023 · 2ee619f · 2ee619f
1 parent 12f1cfd
commit 2ee619f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/src/bunit.web.testcomponents/bunit.web.testcomponents.csproj b/src/bunit.web.testcomponents/bunit.web.testcomponents.csproj
@@ -21,8 +21,8 @@
  <ItemGroup>
  <PackageReference Include="SourceFileFinder" Version="1.1.0" />
  <PackageReference Include="xunit.assert" Version="2.4.2" />
- <PackageReference Include="xunit.extensibility.core" Version="2.5.0" />
- <PackageReference Include="xunit.extensibility.execution" Version="2.5.0" />
+ <PackageReference Include="xunit.extensibility.core" Version="2.4.2" />
+ <PackageReference Include="xunit.extensibility.execution" Version="2.4.2" />
  </ItemGroup>
 
  <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.1'">

diff --git a/tests/Directory.Build.props b/tests/Directory.Build.props
@@ -20,10 +20,14 @@
  <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
  <PackageReference Include="NSubstitute" Version="5.0.0" />
  <PackageReference Include="Shouldly" Version="4.2.1" />
- <PackageReference Include="xunit" Version="2.5.0" />
- <PackageReference Include="Xunit.Combinatorial" Version="1.6.24" />
  <PackageReference Include="coverlet.msbuild" Version="6.0.0" PrivateAssets="All" />
- <PackageReference Include="xunit.runner.visualstudio" Version="2.5.0">
+ <PackageReference Include="Xunit.Combinatorial" Version="1.6.24" />
+ </ItemGroup>
+
+ <ItemGroup>
+ <!-- DO NOT UPGRADE TO versions > 2.4.2 as they do not support .net5 or older -->
+ <PackageReference Include="xunit" Version="2.4.2" />
+ <PackageReference Include="xunit.runner.visualstudio" Version="2.4.2">
  <PrivateAssets>all</PrivateAssets>
  <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
  <NoWarn>NU1701</NoWarn>

diff --git a/tests/bunit.web.testcomponents.tests/bunit.web.testcomponents.tests.csproj b/tests/bunit.web.testcomponents.tests/bunit.web.testcomponents.tests.csproj
@@ -8,9 +8,7 @@
  </PropertyGroup>
 
  <ItemGroup>
- <PackageReference Include="xunit.extensibility.core" Version="2.5.0" />
- <PackageReference Include="xunit.extensibility.execution" Version="2.5.0" />
- <PackageReference Include="xunit.runner.utility" Version="2.5.0" />
+ <PackageReference Include="xunit.runner.utility" Version="2.4.2" />
  <PackageReference Update="Shouldly" Version="4.1.0">
  <!-- some test fails with > 4.1.0 -->
  <NoWarn>NU1605</NoWarn>