Primitive collection API updates #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 0-arg factory method for ByteSet - Convert array parameter to varargs - Add "WithExpectedSize" suffix to method name where a size is expected - Make LongOpenHashSet's collection copying factory method null-safe - Remove LongSet to Set<Long> adapter and unmodifiable LongSet creating method
- Convert array parameter to varargs - Add "WithExpectedSize" suffix to method name where a size is expected - Expose FloatList through PrimitiveLists
- Add "WithExpectedSize" suffix to method name where a size is expected
...for primitive map wrappers
...to load factory classes for in api bundle Add fastutil jar to properly serialize actual collection impl classes.
| if (!(other.get(key) == null && other.containsKey(key))) | ||
| return false; | ||
| } else { | ||
| if (value.equals(other.get(key))) { |
There was a problem hiding this comment.
You now have to write it down hundred times. 😄
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
hashCode()andequals()implementations to fastutil wrapper classesPrimitiveMaps,PrimitiveSetsandPrimitiveListsfactories tocollection.apibundleServiceLoaderwhen looking up the factory implementations for map, set and list collection factory interfacesfastutil-7.0.12.jaras embedded dependency tocollections.fastutilbundle to properly enable serialization of primitive collection wrappers in non-RPC net4j protocols (like RF2 import).Related issue: https://snowowl.atlassian.net/browse/SO-1952