Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort resource search result by type #892

Merged
merged 5 commits into from
Sep 15, 2021

Conversation

molnarlaura
Copy link
Contributor

No description provided.

@molnarlaura molnarlaura self-assigned this Sep 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021

Codecov Report

Merging #892 (4bba6e2) into 8.x (7c0539b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                8.x     #892      +/-   ##
============================================
+ Coverage     62.73%   62.75%   +0.02%     
- Complexity    11584    11588       +4     
============================================
  Files          1711     1711              
  Lines         55294    55320      +26     
  Branches       5301     5307       +6     
============================================
+ Hits          34686    34718      +32     
+ Misses        18410    18397      -13     
- Partials       2198     2205       +7     
Impacted Files Coverage Δ
...tional/snowowl/core/internal/ResourceDocument.java 93.40% <ø> (ø)
...nowowl/core/rest/resource/ResourceRestService.java 96.96% <100.00%> (+0.96%) ⬆️
...x/src/com/b2international/index/util/JsonDiff.java 75.29% <0.00%> (-2.36%) ⬇️
...index/src/com/b2international/index/es/EsNode.java 81.25% <0.00%> (-1.05%) ⬇️
...ed/datastore/converter/SnomedConceptConverter.java 84.84% <0.00%> (-0.62%) ⬇️
...atastore/converter/SnomedDescriptionConverter.java 47.89% <0.00%> (+0.07%) ⬆️
...tastore/converter/SnomedRelationshipConverter.java 46.77% <0.00%> (+0.10%) ⬆️
.../snomed/core/ecl/SnomedEclRefinementEvaluator.java 86.43% <0.00%> (+0.26%) ⬆️
...ex/src/com/b2international/index/query/SortBy.java 57.14% <0.00%> (+3.17%) ⬆️
...national/snowowl/core/locks/OperationLockInfo.java 46.66% <0.00%> (+3.33%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c0539b...4bba6e2. Read the comment docs.

Laura Alexandra Molnár and others added 2 commits September 15, 2021 14:37
…onal/snowowl/core/rest/resource/ResourceRestService.java

Co-authored-by: András Péteri <[email protected]>
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one small change request. 🛩️

@apeteri apeteri merged commit a7caec3 into 8.x Sep 15, 2021
@apeteri apeteri deleted the improvement/sort-search-result-by-type branch September 15, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants