Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO-4923: Index ancestor bundle identifiers on resources #891

Merged
merged 12 commits into from
Sep 8, 2021

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Sep 7, 2021

Access control was also extended to allow or disallow access to nested bundles.

@apeteri apeteri added the feature label Sep 7, 2021
@apeteri apeteri self-assigned this Sep 7, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #891 (10a51b0) into 8.x (f3cae65) will increase coverage by 0.06%.
The diff coverage is 95.68%.

Impacted file tree graph

@@             Coverage Diff              @@
##                8.x     #891      +/-   ##
============================================
+ Coverage     62.67%   62.73%   +0.06%     
- Complexity    11549    11565      +16     
============================================
  Files          1712     1712              
  Lines         55166    55237      +71     
  Branches       5284     5292       +8     
============================================
+ Hits          34573    34653      +80     
+ Misses        18405    18392      -13     
- Partials       2188     2192       +4     
Impacted Files Coverage Δ
...owowl/core/rest/domain/BaseResourceRestSearch.java 53.84% <33.33%> (-6.16%) ⬇️
...om/b2international/snowowl/core/bundle/Bundle.java 48.21% <88.88%> (+7.78%) ⬆️
...nowowl/core/rest/resource/ResourceRestService.java 96.00% <94.11%> (+36.00%) ⬆️
...nowowl/core/request/BaseResourceUpdateRequest.java 89.21% <97.77%> (+3.92%) ⬆️
...b2international/index/revision/RevisionBranch.java 94.78% <100.00%> (ø)
...wl/core/rest/codesystem/CodeSystemRestService.java 94.87% <100.00%> (+0.13%) ⬆️
...src/com/b2international/snowowl/core/Resource.java 98.18% <100.00%> (+0.10%) ⬆️
...nternational/snowowl/core/TerminologyResource.java 88.33% <100.00%> (+0.19%) ⬆️
...ional/snowowl/core/bundle/BundleDeleteRequest.java 100.00% <100.00%> (ø)
...ernational/snowowl/core/codesystem/CodeSystem.java 52.17% <100.00%> (+1.06%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3cae65...10a51b0. Read the comment docs.

Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmark cmark merged commit 04db421 into 8.x Sep 8, 2021
@cmark cmark deleted the feature/SO-4923_ancestor_bundle_ids branch September 8, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants