Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNRAY-315: Add support for resource URIs with timestamp part #887

Merged
merged 5 commits into from
Sep 1, 2021

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Aug 31, 2021

The format changes to {type}/{name}[/{path}][@{timestamp}], where both path and timestamp are optional. The timestamp should be a valid 64-bit value. Resource names and paths may not contain any 'at' characters.

@apeteri apeteri self-assigned this Aug 31, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #887 (1e06e77) into 8.x (41bc2a5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                8.x     #887      +/-   ##
============================================
+ Coverage     62.65%   62.66%   +0.01%     
- Complexity    11541    11546       +5     
============================================
  Files          1712     1712              
  Lines         55144    55165      +21     
  Branches       5281     5284       +3     
============================================
+ Hits          34548    34570      +22     
+ Misses        18406    18404       -2     
- Partials       2190     2191       +1     
Impacted Files Coverage Δ
.../com/b2international/snowowl/core/ResourceURI.java 75.47% <100.00%> (+5.01%) ⬆️
...owowl/core/context/TerminologyResourceRequest.java 70.58% <100.00%> (+2.84%) ⬆️
...owowl/core/uri/DefaultResourceURIPathResolver.java 84.09% <100.00%> (+2.03%) ⬆️
.../datastore/request/rf2/SnomedRf2ExportRequest.java 76.89% <100.00%> (+0.17%) ⬆️
...national/snowowl/core/locks/OperationLockInfo.java 43.33% <0.00%> (-3.34%) ⬇️
...national/index/revision/BaseRevisionBranching.java 85.06% <0.00%> (-1.30%) ⬇️
...index/src/com/b2international/index/es/EsNode.java 81.25% <0.00%> (-1.05%) ⬇️
.../snomed/core/ecl/SnomedEclRefinementEvaluator.java 86.17% <0.00%> (+0.26%) ⬆️
...ernational/snowowl/internal/eventbus/EventBus.java 67.82% <0.00%> (+0.49%) ⬆️
...nternational/snowowl/core/events/util/Promise.java 71.42% <0.00%> (+1.78%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41bc2a5...1e06e77. Read the comment docs.

Copy link
Contributor

@molnarlaura molnarlaura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@apeteri apeteri merged commit 07ff9f5 into 8.x Sep 1, 2021
@apeteri apeteri deleted the feature/SNRAY-315_resource_URI_with_timestamp branch September 1, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants