feat: support dialectId and dialect filters in ECL evaluation
#875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the current CodeSystem.settings.languages configuration key to detect known dialect aliases and convert them to a set of language reference set IDs.
Codecov Report
@@ Coverage Diff @@
## 8.x #875 +/- ##
============================================
+ Coverage 61.38% 61.42% +0.04%
- Complexity 11507 11528 +21
============================================
Files 1714 1714
Lines 56243 56301 +58
Branches 5395 5406 +11
============================================
+ Hits 34525 34585 +60
+ Misses 19522 19521 -1
+ Partials 2196 2195 -1
Continue to review full report at Codecov.
|
Added a few minor ECL evaluation improvements to property evaluations.
apeteri
approved these changes
Aug 12, 2021
| Operator op = Operator.fromString(dialectAliasFilter.getOp()); | ||
| switch (op) { | ||
| case EQUALS: | ||
| dialectQuery.should(Expressions.matchAny(key + "In", values)); |
There was a problem hiding this comment.
A bit magical 🧙 The expression can break if either the keyword in the grammar or the document field names change.
There was a problem hiding this comment.
Yeah, I know, I wanted to spare a bunch of if statements and explicit calls to acceptableIn, preferredIn expression helper calls. 😅 Suggestions to improve this piece of code are welcome. 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the current
CodeSystem.settings.languagesconfiguration key to detect known dialect aliases and convert them to a set of language reference set IDs.