CDO memory leaks #87
Merged
CDO memory leaks #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...TransactionPackageRegistries See: https://github.com/eclipse/cdo/commit/a43fe5c2dd9d0c43d4467ba58e8c19a79d196a31
Replaced ThreadLocal FeatureDeltaWriters in class mapping implementations with new instances. See cdo bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=481721
| { | ||
| EMFUtil.addAdapter(ePackage, packageInfo); | ||
| if (resolve) | ||
| packageRegistry.registerPackageInfo(ePackage, packageInfo); |
There was a problem hiding this comment.
The commit in CDO places this line above the if (resolve) statement: https://github.com/eclipse/cdo/commit/122b20e5a0bbad29bff306188a56357d196f94b3#diff-a67ac632b1a52a49d90610d7b78779f1R246
But why? 😕
|
Do we need this null-checking bit for |
|
👍 otherwise. |
|
Not sure, you can cherry pick it if you want to. 😄 |
apeteri
pushed a commit
to IHTSDO/snow-owl
that referenced
this pull request
Sep 9, 2016
Backports the fixes for the following CDO bugreports to our version: - https://bugs.eclipse.org/bugs/show_bug.cgi?id=405774 - https://bugs.eclipse.org/bugs/show_bug.cgi?id=405781 - https://bugs.eclipse.org/bugs/show_bug.cgi?id=406068 - https://bugs.eclipse.org/bugs/show_bug.cgi?id=481721
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports the fixes for the following CDO bugreports to our custom CDO 4.1.x version: