SO-4731: Update ECL to version 1.5 #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A large number of subclasses have been replaced with a comparison operator.
- Extract IParser, IResourceValidator and ISerializer creation to local variables - Update syntax error messages
cmark
requested changes
Jun 23, 2021
There was a problem hiding this comment.
Looks great so far! Resolve the issues in the b2ihealthcare/snomed-ecl#4 PR first, then here. We will merge the language PR first then this.
snomed/com.b2international.snowowl.snomed.datastore/META-INF/MANIFEST.MF
Show resolved
Hide resolved
|
@apeteri could you please resolve the conflict? Thanks! |
|
This is the commit that introduces I haven't found anything that uses the concrete classes outside of |
|
This pull request introduces 1 alert when merging a849cd6 into 70f0962 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality from QL is included in the update.