SO-4800: RF2 import incorrect release flag #802
Conversation
| assertEquals(EffectiveTimes.parse("2021-05-02"), conceptBefore.getEffectiveTime()); | ||
| assertTrue(conceptBefore.isReleased()); | ||
| assertEquals(EffectiveTimes.toDate(EffectiveTimes.UNSET_EFFECTIVE_TIME), conceptAfter.getEffectiveTime()); | ||
| assertFalse(conceptAfter.isReleased()); |
There was a problem hiding this comment.
This doesn't seem right. When a component has been released, it should stay released – it is a one-way switch to indicate that a downstream consumer of terminology content might have already "seen" the component as part of an RF2 export, and authors should/may not delete it completely (and later, possibly, recycle the ID for a completely different concept).
There was a problem hiding this comment.
Changed the test case to check that the component stays released if it was released before import. And changed the import logic based on this as well.
Codecov Report
@@ Coverage Diff @@
## 7.x #802 +/- ##
=========================================
Coverage 61.52% 61.52%
- Complexity 10944 10946 +2
=========================================
Files 1589 1589
Lines 53531 53534 +3
Branches 5302 5303 +1
=========================================
+ Hits 32933 32936 +3
Misses 18463 18463
Partials 2135 2135
Continue to review full report at Codecov.
|
No description provided.