SO-4724 Selective language refset member inactivation bug #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagyo
requested changes
Mar 23, 2021
| updateComponent(branchPath, SnomedComponentType.DESCRIPTION, descriptionId, inactivateRequestBody).statusCode(204); | ||
| SnomedDescription description = getComponent(branchPath, SnomedComponentType.DESCRIPTION, descriptionId, "members()") | ||
| .extract().as(SnomedDescription.class); | ||
| assertTrue(description.getAcceptabilityMap().containsKey(Concepts.REFSET_LANGUAGE_TYPE_US)); |
There was a problem hiding this comment.
I would also validate that the description is indeed inactive, plus the UK language refset member is inactive and the US language refset member is still active, otherwise this test does not cover the code changes in the change processor class.
There was a problem hiding this comment.
Well, it is sort of covered, but the status of the language refset members is the key point here
|
Closed as there is no need for selective language refset member inactivation. |
AAAlinaaa
deleted the
isssue/SO-4724-selective_rlr_member_inactivation_bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.