SO-1922 proximal primitive algorithm fixes #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix, move and improve getProximalPrimitiveParents algorithm.
| // if the current candidate is a subtype of any already visited nodes, then replace those nodes | ||
| if (isSubTypeOf(primitiveAncestorId, id)) { | ||
| proximalPrimitiveParentIds.remove(id); | ||
| proximalPrimitiveParentIds.add(primitiveAncestorId); |
There was a problem hiding this comment.
Can the following scenario happen:
primitiveAncestorIdwins over 1..n existingids in the set, removing them;- one of the remaining
ids (let's call itwinningId) wins overprimitiveAncestorId?
In this case, it is good that we figured out that winningId should have removed the 1-n ids before, but we should not add primitiveAncestorId either.
There was a problem hiding this comment.
I've added a couple more test cases to verify the algorithm, it seems to work properly. If you manage to come up with a counterexample, please let me know. 😄
There was a problem hiding this comment.
Concerns were alleviated after careful consideration. 😸
|
This performance improvement would also be useful to the IHTSDO. Their SCA tooling doesn't allow creating children or siblings as in Snow Owl, but they build a graphical authoring form that requires the proximate primitive parent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix, move and improve getProximalPrimitiveParents algorithm.