-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[icons] Include additional icon hierarchies based on semantic tags #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmark
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ivelina-yordanova
referenced
this pull request
in babylonhealth/snow-owl
Jul 6, 2020
* SO-4029: Generate worklist for mappings * Revert "SO-4029: Generate worklist for mappings" This reverts commit 6d08ec3. * SO-4029: Generate work list for mappings * SO-4028: Support exclusions from merge operation * SO-4028: Use passed in exclusion id set in StagingArea * SO-4028: Add exclusion merge revision branch index test case * SO-4028: Avoid concurrent map modification * SO-4101: Add generic terminology query optimization request An initial implementation for SNOMED CT is also included that always suggests adding the same (single) expression to the list of inclusions. * SO-4103: add new validation rule for inactive members * SO-4101: Implement direct descendant compacting optimization... ...for SNOMED CT query expressions If the following single concept inclusions exist: =c1, =c2, =c3, ... =cn And a common ancestor concept c4 exists where the following expression is true: <c4 === [c1, c2, c3, ..., cn] Then suggest removing the original "n" single concept references and adding <c4 to the inclusions. * SO-4029: Create generic member domain, search * SO-4028: Track excluded objects without removing from staged objects * SO-4029: Test the generic member search API from the SNOMEDCT side * [icons] Include additional icon hierarchies based on semantic tags (#582) * SO-4028: Rename, overload exclude method * SO-4103: remove sysout * SO-4103: change order of equation * SO-4101: Add "since" tag to QueryOptimizeRequest * SO-4094: Add ComponentURI support to snowowl.core * SO-4028: Create merge exclude tests for changed, remvoed, new revisions * SO-4028: Use varargs, defensive copy in merge operation exclude setters * SO-4100:Check if description already exists... ...in Description Inactivation Indicator refset to not create duplicate members * SO-4028: Create private method to get filtered staged objects * SO-4094: Refactor ComponentURI constructors * SO-4094: Remove semicolons from the end of method bodies * SO-4094: Reverse check argument logic, fix typo * SO-4028: Remove unnecessary check * SO-4028: Use ImmutableSet in defensive copy * SO-4100: Use multimap for refSetMembers * SO-4100: Filter for active members and members... ...with Concept non-current inactivation indicator * [tests] fix ComponentURI related compile error * [core] add URI to generic Concept model * SO-4113 Minor Permission class changes. * SO-4029: Fix hardcoded codesystem uri * SO-4029: Make request, builder classes final * SO-4029: Add locales support to member search request evaluator * SO-4029: Refactor SetMemberSearch API * Use new ComponentURI to store referenced component * Add json deserialization annotiations to SetMember * Fix method name typo * Add sort by option to member evaluation request * Return all members in SNOMED CT member search if no set id is specified * Extend SNOMED CT set member evaluation to other component types besides concepts * SO-4029: Use fsn expand to obtain set member terms * SO-4103: fix rule * SO-4029: Fix ComponentURI initialization errors * SO-4103: add test for rule 671 * SO-4029: Add JSON deserialization annotations to collection resource * [core] omit -1 and ROOT concepts when optimizing queries * SO-4029: Remove BaseComponent as SetMember superclass, make all ... ...fields final, add equals, hashcode toString methods * SO-4029: Use a weak interner to cache ComponentURI instances * SO-4113 Enabled file-style wildcards (*,?) for permission resources. * SO-4029: Use MoreObjects.toStringHelper * SO-4029: Shift jackson annotation to factory method, use obj references * SO-4094: Fix ComponentURI initialization https://snowowl.atlassian.net/browse/SO-4094 * SO-4029: Add support for multi-valued filtering by Set ID * SO-4091: Add known semantic tags as icons, to be used in icon ID... ...computation * SO-4091: Collapse multiple '_' separators in IconIdUpdater * SO-4100: Add filter for description type... ...referenced component * SO-4100: Remove filter * SO-4091: Use hierarchical iconId computation on metadata concepts * SO-4100: Add filter by referencedComponentIds * SO-4103: add new cases for testing rule 671 * SO-4103: change filtering logic * [owl axiom] Update owl axiom member expressions on member update * SO-4103: fix test * SO-4103: refactor script * SO-4100: extract inactivation/reactivation test cases to another class * SO-4100: add description status/indicator checks to inactivation tests * SO-4100 #resolve * [snomed] calculate class/gci axiomRelationships for OWL members... ...regardless of their status Rename AbstractSnomedOWLExpressionMemberCreateDelegate to SnomedOWLExpressionMemberCreateDelegate. Remove SnomedOWLAxiomMemberCreateDelegate and SnomedOWLOntologyMemberCreateDelegate. * SO-4103: rename variable * [owl axioms] Add owl axiom relationship update test * [owl axioms] Uncomment junit test annotations * [tests] update mini RF2 from 2018-01-31 to 2020-01-31 * [snomed] prevent creating Class/GCI OWL Axiom members... ...with inconsistent referencedComponentIds/focusConceptIds. Fix `owlExpression` member field update test. * [fhir] fix failed tests after bumping RF2 test data to 20200131 * [core] support `.` and `~` characters in branch names * [core] support `CodeSystemEntry` and `CodeSystemVersionEntry`... ...in `TransactionContext.delete(Object, boolean)` * [core] fix unrecognized object error messages * SO-4029: change codeSystem field type to CodeSystemURI * SO-4029: add CodeSystemURI alternative ctor and request build method * SO-4029: fix RF2 import content vs release type validation * [vs] support query evaluation in non SNOMED terminologies * [vs] fix getIds() * SO-3387: Use curator, index snapshot config from farmyard environments * SO-3387: Add last 10 snapshot keeping action, example crontab entry... ...to curator.md * [owl authoring] check if there is at least one axiom or relationship * [core] Add helper method to retrieve authorized system bus * [validation] connect filtering with toolingId * [core] make TransactionContexts reusable for subsequent commits Support CodeSystemURI in all branch path based requests Deprecate old repositoryId + branch request build methods. Add throws declaration to LockRequest.doExecute(C). * [core] index read request wrapping in RepositoryCommitRequestBuilder Fix nested request validation in DelegatingRequest. * [core] support extracting ids from ID|TERM| like query strings * [core] fix multiple tooling ID filter issues * [validation] use toolingIDs to filter details by corresponding tooling.. ...specific queries only * [api] allow creating SNOMED CT Concepts without any relationship/axiom * [api] move upload method to Attachment class AttachmentRegistry uses proxy method invocation to call server side upload method, but it proxies the defaults methods as well, which makes it impossible to have those methods on this interface. * [core] add support for ID|TERM| like concept String format ser/deser * [core] add CodeSystemURI.branch helper method * [core] Allow all terminology components to be used as map target types (#599) * [core] add Collections3.equals method * [core] Use single boolean property in TerminologyComponent annotation... ...to determine whether a component is allowed to participate in a SNOMED CT map type reference member as the map target. * [core] Use single boolean property in TerminologyComponent annotation... (#601) ...to determine whether a component is allowed to participate in a SNOMED CT map type reference member as the map target. * [core] add javadoc to Concept.fromConceptString and toConceptString * Constants extracted. * [snomed] add allowed active component attribute values to refset util * [core] add generic DescendantsExpander base class Extract SNOMED CT Concept descendants expand to SnomedDescendantsExpander. Require `direct` parameter to be specified to follow API best practices. * move Files.lines() into try with resources block * [snomed] Fix option key for extended locales in search request evaluator * [validation] override tooling ruleIds with the user specified ruleIds * [releng] update changelog with 7.7.0 changes * [releng] release 7.7.0 * bbl plugin update * rename file * CHR-2455 Co-authored-by: aalaswadi <[email protected]> Co-authored-by: András Péteri <[email protected]> Co-authored-by: Laura Molnár <[email protected]> Co-authored-by: Gabriella Deak <[email protected]> Co-authored-by: Mark Czotter <[email protected]> Co-authored-by: Balazs Banfai <[email protected]> Co-authored-by: Gabor Nagy <[email protected]> Co-authored-by: Kovacs Tamas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a freshly imported dataset, the icons mentioned in the original ticket look like the following: