SO-3933: Export last released version of unpublished content #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmark
requested changes
May 4, 2020
| } | ||
| } | ||
|
|
||
| private String getLatestVersionPath(RepositoryContext context, String branchPath) { |
There was a problem hiding this comment.
Hmm, it would be better to let the request compute the necessary paths to consider when exporting and let the Rf2Exporter just export the data. Now we have a mixed implementation due to one use case, which makes the class harder to understand. We need to come up with a better solution.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Superseded by #1161 |
cmark
deleted the
issue/SO-3933-snapshot_export_unpublished_components_bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.