SO-3760: Validate the character limits of descriptions #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagyo
requested changes
Sep 24, 2019
| @@ -375,6 +375,8 @@ private Concepts() { } | |||
| public static final String PRODUCT_TERM_PLURAL = "69701000132106"; | |||
| public static final String SEARCH_TERM = "9221000132108"; | |||
| public static final String SHORT_NAME = "9211000132103"; | |||
| public static final String THIRTY_CHAR_SHORT_NAME = "9241000132102"; | |||
| public static final String SIXTY_CHAR_SHORT_NAME = "9251000132104"; | |||
There was a problem hiding this comment.
If description length validation is going to be dynamic based on values of the Description Type reference set then these constants are not needed at all. Keeping customer specific constants away from the snow-owl repo is something we are trying to achieve in general. I will keep this PR open until the necessary changes are made. Let me know if you don't have any more changes in this repo and I will close this.
|
Closing as not needed. |
nagyo
deleted the
issue/SO-3760-description_character_limit_validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.