Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Java 11 (7.x) #295

Merged
merged 72 commits into from
Aug 6, 2019
Merged

Support Java 11 (7.x) #295

merged 72 commits into from
Aug 6, 2019

Conversation

zoliMolnar
Copy link

This pull request adds minimalistic support for Java 11.

Zoltan Molnar added 10 commits November 14, 2018 14:09
Conflicts:
	CHANGELOG.md
	commons/com.b2international.collections.fastutil/.classpath
	commons/com.b2international.commons/.classpath
	commons/com.b2international.commons/META-INF/MANIFEST.MF
	commons/com.b2international.index/.classpath
	commons/com.b2international.index/src/com/b2international/index/es/EsDocumentSearcher.java
	commons/com.b2international.mapdb/.classpath
	core/com.b2international.snowowl.datastore/src/com/b2international/snowowl/datastore/request/version/CodeSystemVersionCreateRequest.java
	core/com.b2international.snowowl.fhir.api.tests/src/com/b2international/snowowl/fhir/tests/SandBoxRestTest.java
	core/com.b2international.snowowl.identity.file/.classpath
	core/com.b2international.snowowl.identity.file/META-INF/MANIFEST.MF
	dependencies/com.b2international.snowowl.hibernate.validator/.classpath
	dependencies/com.b2international.snowowl.hibernate.validator/META-INF/MANIFEST.MF
	dependencies/org.supercsv/.classpath
	dependencies/org.supercsv/META-INF/MANIFEST.MF
	pom.xml
	releng/target-platform/.launch/snow-owl-oss.launch
	snomed/com.b2international.snowowl.snomed.api.rest.tests/src/com/b2international/snowowl/snomed/api/rest/branches/SnomedMergeApiTest.java
	snomed/com.b2international.snowowl.snomed.datastore.tests/META-INF/MANIFEST.MF
	snomed/com.b2international.snowowl.snomed.datastore/src/com/b2international/snowowl/snomed/datastore/request/SnomedRefSetMemberSearchRequest.java
	tests/com.b2international.restassured-all/.classpath
	tests/com.b2international.restassured-all/META-INF/MANIFEST.MF
@zoliMolnar zoliMolnar self-assigned this Dec 18, 2018
@apeteri
Copy link
Member

apeteri commented Dec 18, 2018

I also have some questions:

  • Did any of the test projects break due to compile errors? I saw this with newer Eclipse releases where the test classpath is separate from regular classes.
  • Does classgraph support PDE devMode classpaths now?

@apeteri
Copy link
Member

apeteri commented Dec 18, 2018

In the Travis build, Tycho did not like JavaSE-11 as an execution environment value: https://travis-ci.org/b2ihealthcare/snow-owl/builds/469543966

@zoliMolnar
Copy link
Author

@apeteri Neither of the test projects broke due to compilation errors.
ClassGraph supports it but currently it has a bug with the newer versions of eclipse (specifically versions from 2018-09). To resolve this I've forked ClassGraph, fixed the bug and opened a PR for it.

@cmark
Copy link
Member

cmark commented Dec 18, 2018

Please bump Tycho to v1.3 to be able to build projects with Java 11.
https://wiki.eclipse.org/Tycho/Release_Notes/1.3

cmark added 23 commits June 24, 2019 15:19
Add custom snowowl.bat and snowowl.sh startup scripts (WIP).
Configure jetty.home and jetty log class during Snow Owl initialization.
@codecov-io
Copy link

Codecov Report

Merging #295 into 7.x will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##                7.x     #295      +/-   ##
============================================
+ Coverage     51.33%   51.33%   +<.01%     
- Complexity    10404    10414      +10     
============================================
  Files          1682     1681       -1     
  Lines         62099    61972     -127     
  Branches       6933     6934       +1     
============================================
- Hits          31876    31812      -64     
+ Misses        27492    27425      -67     
- Partials       2731     2735       +4
Impacted Files Coverage Δ Complexity Δ
...d/datastore/index/entry/SnomedConceptDocument.java 65.08% <ø> (ø) 16 <0> (ø) ⬇️
...ternational/snowowl/api/rest/SnowOwlApiConfig.java 100% <ø> (ø) 13 <0> (ø) ⬇️
...datastore/index/entry/SnomedComponentDocument.java 66.66% <ø> (ø) 4 <0> (ø) ⬇️
...om/b2international/snowowl/core/CoreActivator.java 100% <ø> (+61.9%) 4 <0> (ø) ⬇️
...core/internal/validation/ValidationThreadPool.java 89.47% <ø> (-0.53%) 2 <0> (ø)
...onal/snowowl/datastore/index/RevisionDocument.java 58.62% <ø> (ø) 4 <0> (ø) ⬇️
...2international/snowowl/fhir/api/FhirApiConfig.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ore/index/constraint/SnomedConstraintDocument.java 69.59% <ø> (ø) 19 <0> (ø) ⬇️
...tore/index/entry/SnomedRefSetMemberIndexEntry.java 77.39% <ø> (ø) 70 <0> (ø) ⬇️
...store/index/entry/SnomedDescriptionIndexEntry.java 71.34% <ø> (+0.41%) 20 <0> (ø) ⬇️
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd6a021...d55cf76. Read the comment docs.

@cmark cmark self-assigned this Jul 23, 2019
@cmark cmark removed their request for review July 23, 2019 08:16
@cmark cmark merged commit d55cf76 into 7.x Aug 6, 2019
@cmark cmark deleted the feature/java_11 branch August 8, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants