Support multiple code systems versioning #282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... creating multiple code system versions
cmark
requested changes
Nov 20, 2018
| final IVersioningManager versioningManager = VersioningManagerBroker.INSTANCE.createVersioningManager(codeSystem.getTerminologyComponentId()); | ||
| versioningManagersByCodeSystem.put(codeSystem, versioningManager); | ||
|
|
||
| if (versioningManager.needsOtherCodeSystemsToVersion()) { |
There was a problem hiding this comment.
Not sure if this flag is really required, I would only use the codeSystemDependenciesByRepositoryId() method with a forEach if additional code systems need to be versioned along with the current one.
...rc/com/b2international/snowowl/datastore/request/version/CodeSystemVersionCreateRequest.java
Show resolved
Hide resolved
| .getSync(); | ||
| } | ||
|
|
||
| private void createVersion(ServiceProvider context, IVersioningManager versioningManager, CodeSystemEntry codeSystem, String user) { |
There was a problem hiding this comment.
Reusing this method in a forEach to version all dependent code systems as well long with the current one certainly does its job, but we can improve it to limit the number of unwanted content changes while the versioning runs for a single code system.
Refactor the versioning process to acquire and release locks for all target code systems at once at the beginning and at the end of the process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket reference: https://snowowl.atlassian.net/browse/SDD-901