Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core.domain] Make IComponent an IdProvider #193

Closed
wants to merge 1 commit into from
Closed

[core.domain] Make IComponent an IdProvider #193

wants to merge 1 commit into from

Conversation

AAAlinaaa
Copy link
Contributor

No description provided.

apeteri
apeteri requested changes Jan 25, 2018
View reviewed changes
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"core.domain" and "core.api" views of components would become intermixed with the addition of this interface, which we'd like to keep strictly separated.

@apeteri
Copy link
Member

apeteri commented Jan 25, 2018

Following discussion, the change could be avoided by fixing a call site in a different project. Closing PR.

@apeteri apeteri closed this Jan 25, 2018
@cmark cmark deleted the Make_IComponent_an_IdProvider branch August 8, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeteri apeteri apeteri requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AAAlinaaa @apeteri