Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDD-788: Improve relationship CD member handling in distribution normal form #161

Closed
wants to merge 9 commits into from

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Aug 29, 2017

No description provided.

- Collect all stated relationships
- Collect all inferred relationships
- Collect all stated CD members on any component
- Collect all inferred CD members on any component
- Don't collect component storage keys
- Don't associate non-concept storage keys to their "containing" concept
- Remove change processing mode (collects additional relationships and
CD members)
...restriction instead of assuming that it will be the only element.
This is required because of "preferred order" becoming a stated CD
member, making the converted OWL definition a non-trivial intersection.
...over to the inferred counterpart, keeping the additional
characteristic type, but changing to inferred otherwise. (It is assumed
that a stated relationships will never have inferred CD members to begin
with.)
Also report the statement as being stronger if it contains all CD
members of the other fragment (extra ones also allowed).
@apeteri
Copy link
Member Author

apeteri commented Aug 29, 2017

DataHasValue expressions are still not used because ELK emits a warning in the log each time it is encountered, see https://github.com/liveontologies/elk-reasoner/blob/a3531b73651e4306c2b4e7330dc6092522f41617/elk-reasoner/src/main/java/org/semanticweb/elk/reasoner/stages/InputLoadingStage.java#L336

@apeteri apeteri changed the base branch from 4.x to 6.x January 8, 2018 13:23
@apeteri apeteri changed the base branch from 6.x to 4.x January 8, 2018 13:23
@apeteri
Copy link
Member Author

apeteri commented Jan 8, 2018

I tried to change the base branch, but it added a lot of commits to the list, so it is still on 4.x at the moment.

@apeteri
Copy link
Member Author

apeteri commented Dec 7, 2018

Obsoleted by changes on #288.

@apeteri apeteri closed this Dec 7, 2018
@cmark cmark deleted the feature/SDD-788-cd-generator-changes branch January 20, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant