Bump Eclipse to e4.30 and Tycho to 4.0.4 #1240

cmark · 2023-11-14T12:19:38Z

This PR bumps the target platform to Eclipse Platform 4.30 and Tycho to 4.0.4.

The following dependency changes have been applied:

Upgrade Elasticsearch to 8.12.1
Upgrade Xtext to 2.33.0
Upgrade EMF to 2.35.0
Upgrade MWE2 to 2.16.0
Upgrade ECL to 2.1.5
Upgrade SLF4J to 2.0.11
Upgrade Logback to 1.4.14
Upgrade Jackson to 2.16.1
Upgrade Jetty to 12.0.3
Upgrade to Jakarta EE10
Upgrade Spring to 6.1.3
Upgrade springdoc to 2.3.0
Upgrade swagger to 2.2.20
Upgrade Guava to 32.1.3-jre
Upgrade OWLAPI to 4.5.26
Upgrade Protege to custom 5.0.7
Upgrade snomed-owl-toolkit to a custom 5.1.1
Upgrade Fastutil to 8.5.12
Upgrade RestAssured to 4.5.1
Upgrade Mockito to 5.9.0
Upgrade ByteBuddy to 1.14.11
Upgrade uuid-creator to 5.3.7
Upgrade failsafe to 3.3.2
Upgrade rxjava to 2.2.21
Upgrade netty to 4.1.106.Final
Upgrade kotlin-osgi-bundle to 1.9.22
Upgrade mapdb to 3.1.0
Upgrade failsafe to 3.2.2
Upgrade micrometer to 1.12.2
Upgrade zjsonpatch to 0.4.16
Upgrade bucket4j to 8.7.0
Upgrade hibernate validator to 8.0.1.Final
Upgrade java-jwt to 4.4.0
Upgrade jwks-rsa to 0.22.1
Upgrade testcontainers to 1.19.4
Add required Apache Commons libraries.

Build changes:

Add mvn wrapper
Tycho is now 4.0.4
jacoco is now 0.8.11
Remove unused jars from the produced packages

Jira: https://snowowl.atlassian.net/browse/SO-5973

codecov · 2023-11-14T14:40:21Z

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (67f3753) 47.96% compared to head (cd7a786) 48.17%.

❗ Current head cd7a786 differs from pull request most recent head bb63585. Consider uploading reports for the commit bb63585 to get more accurate results

Files	Patch %	Lines
...nal/collections/deser/CollectionDeserializers.java	0.00%	3 Missing ⚠️
.../collections/deser/CollectionDeserializerBase.java	0.00%	2 Missing ⚠️
...l/snowowl/core/console/SnowOwlCommandProvider.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                9.x    #1240      +/-   ##
============================================
+ Coverage     47.96%   48.17%   +0.21%     
- Complexity    13847    13872      +25     
============================================
  Files          1944     1944              
  Lines         95071    95015      -56     
  Branches      10979    10975       -4     
============================================
+ Hits          45599    45777     +178     
+ Misses        46443    46242     -201     
+ Partials       3029     2996      -33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Drop javax.inject libraries in favor of jakarta.inject (Guice 7.0).

Migrate to springdoc openapi 2.3.0

...security configuration

...jetty environment Fix jetty 12 osgi boot configuration issue by copying files and fixing the erroneous section.

Remove dependency on eclipse.core.net.

...from snomed core module

This updates parsson to 1.0.5 which resolves a security vulnerability issue.

...helpers

apeteri

Looks great at first glance! See feedback below.

cis/com.b2international.snowowl.snomed.cis.product/assembly/common/bin/cis.sh

...l.collections.jackson/src/com/b2international/collections/deser/CollectionDeserializers.java

commons/com.b2international.index.test.tools/elasticsearch-default-memory-vm.options

core/com.b2international.snowowl.core.rest.tests/pom.xml

core/com.b2international.snowowl.core.rest/.classpath

...ernational.snowowl.core.rest/src/com/b2international/snowowl/core/rest/SnowOwlApiConfig.java

snomed/com.b2international.snowowl.snomed.core.rest.tests/pom.xml

releng/com.b2international.snowowl.server.update/snow-owl-oss.product

fhir/com.b2international.snowowl.fhir.rest.tests/pom.xml

…mmon/bin/cis.sh Co-authored-by: András Péteri <[email protected]>

...instead of incorrect VALUE_NUMBER_INT in FloatCollectionDeserializerBase

Due to project references Eclipse will report errors when m2e will try to delete the unwanted but still referenced jars from the lib folder.

nagyo

LGTM! (as much as I was able to go through all the files 😅)

README.md

cis/com.b2international.snowowl.snomed.cis.product/assembly/common/bin/cis.sh

core/com.b2international.snowowl.core.rest.tests/src/configuration/jetty-deploy.xml

- add job parameters to Jenkinsfile

Update Groovy Development Tools update site. Update MWE versions and update site. Update Xtext versions and update site.

apeteri

OK to merge once the README is adjusted and (possibly) the multipart upload configuration is added back to its new place.

README.md

Location will no longer be set by default to `/tmp`, let the servlet container (Jetty) default temporary directory be used instead of a custom directory. The multipart element is still needed in the web.xml to kick-off the necessary servlet initialization logic. Actual max file/request size and file threshold limits will be set when Spring initializes the rest api webapp.

cmark added 2 commits November 14, 2023 09:44

feat(build): bump tycho to 4.0.4

7c7c3fd

refactor: sync all .classpath files with latest eclipse/m2e changes

667a175

cmark added the enhancement label Nov 14, 2023

cmark requested review from apeteri and nagyo November 14, 2023 12:19

cmark self-assigned this Nov 14, 2023

cmark added 4 commits November 14, 2023 13:29

ci: bump gh action packages to their latest version

730052b

build: add mvn wrapper with version 3.9.5

27c9412

docs: update Building from source and Development sections

fab6509

build: use maven wrapper when building on GitHub

f3f468f

refactor: sync test.dependencies/.classpath

fd10d44

cmark added the on hold label Nov 22, 2023

cmark added 17 commits January 11, 2024 10:13

fix: start migrating to newer, 5.0 snomed-owl-toolkit version

2cc7fc4

build: remove snomed-owl-toolkit 3.0.6 from tp

e22864b

chore(deps): depend on Guava 32.1.3-jre

727127a

Drop javax.inject libraries in favor of jakarta.inject (Guice 7.0).

chore(deps): depend on Spring 6.1.3

b6b1a87

Migrate to springdoc openapi 2.3.0

refactor(rest): resolve compile errors after moving to SpringDoc 2.3.0

84e36b3

fix(index): resolve test failures in index tests

5f3e18a

fix(api): migrate SnowOwlSecurityConfig to component based...

4f26620

...security configuration

fix(api): use the new OpenApiService class to access the OpenAPI bean

be09e28

fix(dev): core-e2e-tests.launch configuration plugin list

61c0234

test: add jetty-ee8 variant of core-e2e-tests launch config

9ac9415

fix(test): make sure we try to deploy the rest api into the ee10...

9ce944d

...jetty environment Fix jetty 12 osgi boot configuration issue by copying files and fixing the erroneous section.

fix(test): use PathUtils instead of deprecated FileUtils

99f9ac5

Merge branch '9.x' into bump/eclipse-tycho-build

6be7d59

fix(core): remove unused PlatformUtil.enableSystemProxies()

02c80a8

Remove dependency on eclipse.core.net.

test: add a trace log entry after a bundle successfully started

548081e

test(dev): fix core-e2e-tests launch config on Jetty 12 EE10

93f441e

fix(snomed): remove unnecessary eclipse.core.databinding dependency...

d658dd7

...from snomed core module

cmark added 6 commits February 7, 2024 11:42

chore(tp): explicitly add jetty-session as tp dependency

8fc2cdb

build: remove unused older jetty servlet and websocket api jars

8b5911e

chore(deps): update elasticsearch8 client to 8.12.1

1c2440c

This updates parsson to 1.0.5 which resolves a security vulnerability issue.

chore(deps): upgrade netty to 4.1.106.Final

4290cad

chore(deps): upgrade kotlin to 1.9.22

4a811f8

chore(deps): upgrade mapdb to 3.1.0

9c50159

cmark removed the on hold label Feb 8, 2024

chore(test): improve type consistenty in new query parameter encoder...

5217c1e

...helpers

apeteri requested changes Feb 8, 2024

View reviewed changes

cmark and others added 5 commits February 9, 2024 12:33

Update cis/com.b2international.snowowl.snomed.cis.product/assembly/co…

dd5c48e

…mmon/bin/cis.sh Co-authored-by: András Péteri <[email protected]>

fix(collections): report VALUE_NUMBER_FLOAT missing token...

3162cf6

...instead of incorrect VALUE_NUMBER_INT in FloatCollectionDeserializerBase

chore(dev): remove incorrect classpath source attachment path

88130b7

chore(dev): add m2e directive to ignore folder cleaning in core.rest

6ba4e0c

Due to project references Eclipse will report errors when m2e will try to delete the unwanted but still referenced jars from the lib folder.

build: enable rest api tests

63c410a

nagyo approved these changes Feb 11, 2024

View reviewed changes

nagyo and others added 6 commits February 11, 2024 15:47

chore(releng): remove JDK and Maven version from Jenkins pipeline

75b1088

- add job parameters to Jenkinsfile

chore(deps): upgrade ecl to 2.1.5

eba16a5

chore(deps): upgrade owlapi to 4.5.26.b2i

d8a6c1d

chore(deps): upgrade protege to 5.0.7.b2i

48158f1

chore(deps): use released version of owltoolkit 5.1.1

d763bd5

chore(docs): update Eclipse IDE version

cd7a786

Update Groovy Development Tools update site. Update MWE versions and update site. Update Xtext versions and update site.

apeteri approved these changes Feb 12, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

cmark changed the title ~~Bump Eclipse Tycho to 4.0.4~~ Bump Eclipse to e4.30 and Tycho to 4.0.4 Feb 14, 2024

cmark added 2 commits February 14, 2024 09:48

chore(docs): update latest tested Eclipse version

bb63585

cmark merged commit 7c58d2b into 9.x Feb 14, 2024
1 of 2 checks passed

cmark deleted the bump/eclipse-tycho-build branch February 14, 2024 09:07

cmark added a commit that referenced this pull request Feb 21, 2024

feat(tp): backport changes from PR #1240 to 8.x

8206da8

cmark mentioned this pull request Feb 21, 2024

Upgrade Eclipse Platfom to e4.30 and Tycho to 4.0.4 (8.x) #1257

Merged

cmark added the port-to-8.x Pull requests that need a complementary PR targeting the 8.x stream label Feb 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump Eclipse to e4.30 and Tycho to 4.0.4 #1240

Bump Eclipse to e4.30 and Tycho to 4.0.4 #1240

cmark commented Nov 14, 2023 •

edited

Loading

codecov bot commented Nov 14, 2023 •

edited

Loading

apeteri left a comment

nagyo left a comment

apeteri left a comment

Bump Eclipse to e4.30 and Tycho to 4.0.4 #1240

Bump Eclipse to e4.30 and Tycho to 4.0.4 #1240

Conversation

cmark commented Nov 14, 2023 • edited Loading

codecov bot commented Nov 14, 2023 • edited Loading

Codecov Report

apeteri left a comment

Choose a reason for hiding this comment

nagyo left a comment

Choose a reason for hiding this comment

apeteri left a comment

Choose a reason for hiding this comment

cmark commented Nov 14, 2023 •

edited

Loading

codecov bot commented Nov 14, 2023 •

edited

Loading