Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): extract sort pattern generation to SortSupport helper #1236

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

cmark
Copy link
Member

@cmark cmark commented Nov 9, 2023

No description provided.

@cmark cmark requested review from apeteri and nagyo November 9, 2023 17:07
@cmark cmark self-assigned this Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (14d6882) 64.08% compared to head (869f1bc) 64.10%.

Additional details and impacted files
@@             Coverage Diff              @@
##                9.x    #1236      +/-   ##
============================================
+ Coverage     64.08%   64.10%   +0.01%     
- Complexity    13156    13159       +3     
============================================
  Files          1795     1796       +1     
  Lines         61466    61468       +2     
  Branches       5708     5708              
============================================
+ Hits          39393    39401       +8     
+ Misses        19605    19600       -5     
+ Partials       2468     2467       -1     
Files Coverage Δ
...ational/snowowl/core/rest/AbstractRestService.java 100.00% <100.00%> (+7.69%) ⬆️
...international/snowowl/core/domain/SortSupport.java 88.23% <88.23%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmark cmark marked this pull request as ready for review November 10, 2023 12:52
@cmark cmark merged commit 33a387c into 9.x Nov 10, 2023
5 checks passed
@cmark cmark deleted the issue/SO-5927-sort-improvements branch November 10, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants