Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce shortcuts to frequently used index settings #1232

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Oct 17, 2023

This PR makes the following properties available on ServiceProvider:

  • getPageSize
  • getTermPartitionSize
  • getCommitLimit

Existing call chains in client classes were converted to the short form as well.

@apeteri apeteri requested review from cmark and nagyo October 17, 2023 11:36
@apeteri apeteri self-assigned this Oct 17, 2023
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓 Awesome work @apeteri!

@cmark cmark merged commit 13e6210 into 9.x Oct 17, 2023
1 of 2 checks passed
@cmark cmark deleted the refactor/index_settings_access branch October 17, 2023 11:59
@nagyo
Copy link
Member

nagyo commented Oct 17, 2023

💯 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants