Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SO-5877: core API changes necessary for the new upgrade flow #1211

Merged
merged 19 commits into from
Sep 15, 2023
Merged

SO-5877: core API changes necessary for the new upgrade flow #1211

merged 19 commits into from
Sep 15, 2023

Conversation

cmark
Copy link
Member

@cmark cmark commented Sep 14, 2023

No description provided.

@cmark
chore(test): remove deprecated /upgrade endpoint from ApiTestConstants
68bd63a
@cmark
fix(core): throw bad request instead of not found when...
9408afd 
...the resource to version cannot be found
@cmark
fix(test): extract constant to superclass
ebcfa50
@cmark
chore(core): remove deprecated availableUpgrades() expand option
7cda407 
Replaced by `dependencies_upgrades()` expand.
@cmark
feat(index): support tilde ~ in default allowed branch character set
6161f29
@cmark
Merge remote-tracking branch 'origin/9.x' into feature/SO-5877-collec…
bc2543c 
…tion-upgrade
@cmark
refactor(core): remove deprecated upgradeInfo expand option
33d3d3e 
Remove deprecated extensionOfBranchState expand option.
@cmark
refactor(core): remove extensionOfBranchInfo field from termresource
6d10932
@cmark
feat(core): add child and sibling helpers to IBranchPath
597caf2
@cmark
feat(core): search branches using their stored path aliases as well
2163396
@cmark
refactor(core): remove old codesystem specific synchronization request
7335ae9
@cmark
refactor(core): remove old extensionOf and upgradeOf fields...
4dae76a 
...from TerminologyResource
@cmark
refactor(core)!: remove old extensionOf and upgradeOf fields from API
134e7ce 
Keep backward compatibility on document level and auto-migrate to the
new dependencies model without using any of the previous fields.

https://snowowl.atlassian.net/browse/SO-5888
@cmark
fix(core): incorrect logic in hasDependency(String) helper
33cc403
@cmark cmark added the feature label Sep 14, 2023
@cmark cmark requested review from apeteri and nagyo September 14, 2023 15:58
@cmark cmark self-assigned this Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited
Loading

Codecov Report

Patch coverage: 84.76% and project coverage change: +0.20% 🎉

Comparison is base (f2b6233) 64.11% compared to head (b9d9d1a) 64.32%.
Report is 3 commits behind head on 9.x.

❗ Current head b9d9d1a differs from pull request most recent head 02a53bd. Consider uploading reports for the commit 02a53bd to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##                9.x    #1211      +/-   ##
============================================
+ Coverage     64.11%   64.32%   +0.20%     
+ Complexity    13155    13133      -22     
============================================
  Files          1799     1796       -3     
  Lines         61594    61321     -273     
  Branches       5696     5676      -20     
============================================
- Hits          39491    39443      -48     
+ Misses        19663    19444     -219     
+ Partials       2440     2434       -6
Files Changed Coverage Δ
...b2international/index/revision/RevisionBranch.java 94.30% <ø> (ø)
...ore/rest/codesystem/CodeSystemUpdateRestInput.java 100.00% <ø> (ø)
.../b2international/snowowl/core/api/IBranchPath.java 0.00% <0.00%> (ø)
...rnational/snowowl/core/bundle/BundleConverter.java 100.00% <ø> (ø)
...ernational/snowowl/core/codesystem/CodeSystem.java 40.98% <0.00%> (-4.48%) ⬇️
...l/snowowl/core/codesystem/CodeSystemConverter.java 100.00% <ø> (+91.66%) ⬆️
...ore/codesystem/CodeSystemCreateRequestBuilder.java 100.00% <ø> (+14.28%) ⬆️
...owowl/core/codesystem/CodeSystemSearchRequest.java 91.66% <ø> (-1.67%) ⬇️
...ore/codesystem/CodeSystemSearchRequestBuilder.java 100.00% <ø> (+28.57%) ⬆️
...ore/codesystem/CodeSystemUpdateRequestBuilder.java 100.00% <ø> (ø)
... and 10 more

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

apeteri
apeteri requested changes Sep 15, 2023
View reviewed changes
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things need to be addressed, looks good otherwise!

...ernational.snowowl.core/src/com/b2international/snowowl/core/console/CodeSystemsCommand.java Show resolved Hide resolved
....snowowl.core/src/com/b2international/snowowl/core/request/version/VersionCreateRequest.java Outdated Show resolved Hide resolved
nagyo
nagyo approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor notes 🍏

....snowowl.core/src/com/b2international/snowowl/core/request/version/VersionCreateRequest.java Outdated Show resolved Hide resolved
....snowowl.core/src/com/b2international/snowowl/core/request/version/VersionCreateRequest.java Outdated Show resolved Hide resolved
....snowowl.core/src/com/b2international/snowowl/core/request/version/VersionCreateRequest.java Outdated Show resolved Hide resolved
apeteri
apeteri approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍃

@cmark cmark merged commit 1fec552 into 9.x Sep 15, 2023
1 check passed
@cmark cmark deleted the feature/SO-5877-collection-upgrade branch September 15, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagyo nagyo nagyo approved these changes

@apeteri apeteri apeteri approved these changes

Assignees

@cmark cmark

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmark @apeteri @nagyo