Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Support ResourceURI input for lock/unlock requests #1198

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Aug 31, 2023

No description provided.

@apeteri apeteri requested review from cmark and nagyo August 31, 2023 08:45
@apeteri apeteri self-assigned this Aug 31, 2023
Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a small note

@nagyo
Copy link
Member

nagyo commented Sep 1, 2023

Merging PR with an expected follow-up review from @cmark

@nagyo nagyo merged commit 2e1bc41 into 9.x Sep 1, 2023
1 check passed
@nagyo nagyo deleted the feature/SO-5847-support-resource-uri-in-lock-api branch September 1, 2023 09:20
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, but there is still work to do. The low-level repository + branchPath-based locking mechanism can be marked deprecated and removed from 9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants