SO-5842: core API changes to support resource agnostic upgrade mechanism #1193
Conversation
Expand option key name is WIP.
...from representation
...from SearchResourceRequestBuilder Allow overriding filter options before executing the search request.
commons/com.b2international.commons/src/com/b2international/commons/options/OptionsBuilder.java
Show resolved
Hide resolved
...when resolving a resource uri to an actual branch path. Prevent using special URI paths in dependencies.
...m.b2international.snowowl.core/src/com/b2international/snowowl/core/TerminologyResource.java
Outdated
Show resolved
Hide resolved
...m.b2international.snowowl.core/src/com/b2international/snowowl/core/TerminologyResource.java
Outdated
Show resolved
Hide resolved
...m.b2international.snowowl.core/src/com/b2international/snowowl/core/TerminologyResource.java
Outdated
Show resolved
Hide resolved
| }); | ||
|
|
||
| protected final void expandDependencyUpgrades(List<R> results) { | ||
| if (!expand().containsKey("dependencies_upgrades")) { |
There was a problem hiding this comment.
I thought that we are following java naming conventions for expand keywords? E.g. inboundRelationships, statedDescendants, referenceSet. The wording should probably follow the method's name or the other way around, e.g. dependencyUpgrades, upgradeDependencies
There was a problem hiding this comment.
It would also be nice to save this in a static field somewhere, like:
There was a problem hiding this comment.
This is a temporary expand key, we need dot notation support here, like this dependencies.upgrades() but unfortunately the current expand parser does not like dots in property names and fails to parse the object. A minor refactor is required to make it work so we had to use underscore instead of dot for the separator.
| concept = getConcept(upgradeCodeSystem.getResourceURI(), moduleId); | ||
| assertEquals(effectiveTime, concept.getEffectiveTime()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Please don't forget to add back or refactor these unit tests later on.
There was a problem hiding this comment.
Yup, that's on my to-do list.
| return extensionConcept.getDescriptions().getItems().stream().filter(d -> d.getTerm().equals(extensionFsnTerm)).findFirst().get(); | ||
| } | ||
|
|
||
| } |
…snowowl/core/TerminologyResource.java
…snowowl/core/TerminologyResource.java
…snowowl/core/TerminologyResource.java
…ce-agnostic-upgrades
No description provided.