Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO-5439: Fix dependency resolution during SNOMED CT import #1137

Merged
merged 3 commits into from
Apr 21, 2023

Conversation

nagyo
Copy link
Member

@nagyo nagyo commented Apr 21, 2023

No description provided.

@nagyo nagyo requested review from apeteri and AAAlinaaa April 21, 2023 09:54
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: +0.01 🎉

Comparison is base (287c035) 64.16% compared to head (b5a77f1) 64.18%.

❗ Current head b5a77f1 differs from pull request most recent head 571c427. Consider uploading reports for the commit 571c427 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                8.x    #1137      +/-   ##
============================================
+ Coverage     64.16%   64.18%   +0.01%     
- Complexity    12688    12696       +8     
============================================
  Files          1758     1758              
  Lines         59148    59163      +15     
  Branches       5455     5457       +2     
============================================
+ Hits          37954    37971      +17     
  Misses        18836    18836              
+ Partials       2358     2356       -2     
Impacted Files Coverage Δ
...atastore/request/SnomedOWLExpressionConverter.java 83.50% <80.00%> (-0.41%) ⬇️
...f2/importer/Rf2OwlExpressionRefSetContentType.java 92.59% <100.00%> (+1.68%) ⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with a small request.

@nagyo nagyo self-assigned this Apr 21, 2023
@nagyo nagyo requested a review from cmark April 21, 2023 11:53
@nagyo nagyo merged commit 94e0859 into 8.x Apr 21, 2023
@nagyo nagyo deleted the issue/SO-5439_fix_dependency_resolution_during_sct_import branch April 21, 2023 11:55
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late 🥓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants