SO-2022 Change complex map field types #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this is necessary to support values greater than Byte.MAX_VALUE (127) https://snowowl.atlassian.net/browse/SO-2022 Conflicts: snomed/com.b2international.snowowl.snomed.datastore/src/com/b2international/snowowl/snomed/datastore/index/entry/SnomedRefSetMemberIndexEntry.java snomed/com.b2international.snowowl.snomed.datastore/src/com/b2international/snowowl/snomed/datastore/index/refset/RefSetMemberMutablePropertyUpdater.java snomed/com.b2international.snowowl.snomed.refset.core/src/com/b2international/snowowl/snomed/refset/clone/SnomedRefSetCloner.java
apeteri
approved these changes
Feb 24, 2017
| @@ -67,7 +69,7 @@ private void validateMapCategory(final List<String> row) { | |||
| final String uuid = row.get(0); | |||
| final String effectiveTime = row.get(1); | |||
| final String mapCategory = row.get(12); | |||
| if (!isComponentExists(mapCategory, ReleaseComponentType.CONCEPT)) { | |||
| if (getComponentCategory(mapCategory) == ComponentCategory.CONCEPT && !isComponentExists(mapCategory, ReleaseComponentType.CONCEPT)) { | |||
There was a problem hiding this comment.
I think we should reject reference set rows where the mapCategoryId value is not a valid SCTID. But that also holds true for all reference set validators, not just this one (report an error if one of the component SCTIDs in a column is nonsensical or does not match the expected type).
|
Changing the base of this PR to be included in #131. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complex map's map group and map priority fields were stored as byte which made it impossible to import maps with group/priority numbers higher than Byte.MAX_VALUE (127), so the fields were changed to integer.