Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fhir.core): Add generic "constraint" filter #1063

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Sep 26, 2022

It is handled the same way as SNOMED CT's "expression" filter defined on the FHIR code system resource:

{
  "code" : "expression",
  "description" : "The result of the filter is the result of executing the given SNOMED CT Expression Constraint",
  "operator" : ["="],
  "value" : "A SNOMED CT ECL expression (see https://snomed.org/ecl)"
}

...but is applicable to any code system tooling with ECL support.

@apeteri apeteri self-assigned this Sep 26, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 64.25% // Head: 64.25% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (beaa0d7) compared to base (6c37cd5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##                8.x    #1063      +/-   ##
============================================
- Coverage     64.25%   64.25%   -0.01%     
+ Complexity    12437    12436       -1     
============================================
  Files          1732     1732              
  Lines         58045    58056      +11     
  Branches       5361     5361              
============================================
+ Hits          37298    37304       +6     
- Misses        18446    18450       +4     
- Partials       2301     2302       +1     
Impacted Files Coverage Δ
...al/snowowl/fhir/core/model/codesystem/Filters.java 98.55% <100.00%> (+0.16%) ⬆️
...ernational/snowowl/core/request/DeleteRequest.java 76.92% <0.00%> (-6.42%) ⬇️
...owl/core/identity/AuthorizationHeaderVerifier.java 55.26% <0.00%> (-4.74%) ⬇️
...index/src/com/b2international/index/es/EsNode.java 81.25% <0.00%> (-1.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

@cmark cmark merged commit 019cc62 into 8.x Sep 28, 2022
@cmark cmark deleted the improvement/SNRAY-1004-FHIR-import-changes branch September 28, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants