SO-1974 extension terminology selector #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
June 8, 2016 17:59
to TerminologyRegistryService and to its implementation
the comparison is based on the code system's base version eg.: CodeSystems with these branchPaths MAIN/2016-07-31/SNOMEDCT-DK MAIN MAIN/2016-01-31/SNOMEDCT-DK will be ordered to this: MAIN/2016-01-31/SNOMEDCT-DK (smallest) MAIN/2016-07-31/SNOMEDCT-DK MAIN (biggest)
improoving default terminology extension computation: select the main by default.
| @@ -0,0 +1,15 @@ | |||
| <com.b2international.snowowl.core.api.preferences.ConfigNode> | |||
There was a problem hiding this comment.
If this config is only applicable on the client side, then please remove it from the server assembly.
| return new ActiveCodeSystemPredicate(branchPathMap, repositoryUuid); | ||
| } | ||
|
|
||
| public static Predicate<ICodeSystem> mainCodeSystemPredicate() { |
There was a problem hiding this comment.
Use only a single instance for Predicates and Functions. See the other comment about moving them to the ICodeSystem interface.
added 4 commits
June 15, 2016 16:44
persisting repo UUID to short name rather then POJO
| * | ||
| * Preference configuration for terminology extension selection. | ||
| */ | ||
| public class TerminologyExtensionConfiguration extends PreferenceBase { |
There was a problem hiding this comment.
This class is still available on the server side, could you please move it to the ext repo? Thanks!
cmark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request introduces a new preference page that allows the users to select the extension on which they will do their authoring work