Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO-5406 freeze retired resources #1007

Merged
merged 5 commits into from
Apr 13, 2022
Merged

Conversation

cmark
Copy link
Member

@cmark cmark commented Apr 13, 2022

This PR ensures that retired resources cannot be versioned and their contents cannot be edited unless their status changes back to something else than retired.

...and their content cannot be changed.

Metadata is still allowed to be edited.
@cmark cmark requested a review from apeteri April 13, 2022 15:49
@cmark cmark self-assigned this Apr 13, 2022
@cmark cmark closed this Apr 13, 2022
@cmark cmark force-pushed the issue/SO-5406-freeze-retired-resources branch from a1d3952 to 2e00398 Compare April 13, 2022 15:55
@cmark cmark deleted the issue/SO-5406-freeze-retired-resources branch April 13, 2022 15:57
@cmark cmark restored the issue/SO-5406-freeze-retired-resources branch April 13, 2022 15:57
@cmark cmark reopened this Apr 13, 2022
@cmark cmark force-pushed the issue/SO-5406-freeze-retired-resources branch from f109067 to f272752 Compare April 13, 2022 16:01
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

Codecov Report

Merging #1007 (f272752) into 8.x (d86e0f2) will decrease coverage by 0.00%.
The diff coverage is 28.57%.

❗ Current head f272752 differs from pull request most recent head 7d8589d. Consider uploading reports for the commit 7d8589d to get more accurate results

@@             Coverage Diff              @@
##                8.x    #1007      +/-   ##
============================================
- Coverage     64.68%   64.67%   -0.01%     
- Complexity    12156    12158       +2     
============================================
  Files          1702     1703       +1     
  Lines         56615    56628      +13     
  Branches       5267     5270       +3     
============================================
+ Hits          36621    36625       +4     
- Misses        17760    17769       +9     
  Partials       2234     2234              
Impacted Files Coverage Δ
...src/com/b2international/snowowl/core/Resource.java 86.36% <ø> (ø)
...owowl/core/context/TerminologyResourceRequest.java 65.71% <0.00%> (-1.94%) ⬇️
...request/TerminologyResourceStatusCheckRequest.java 0.00% <0.00%> (ø)
...quest/TerminologyResourceCommitRequestBuilder.java 75.00% <50.00%> (-25.00%) ⬇️
...ore/context/DefaultTerminologyResourceContext.java 100.00% <100.00%> (ø)
...owl/core/request/version/VersionCreateRequest.java 83.58% <100.00%> (+0.24%) ⬆️
...index/src/com/b2international/index/es/EsNode.java 81.25% <0.00%> (-1.05%) ⬇️
...ernational/snowowl/internal/eventbus/EventBus.java 68.31% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d86e0f2...7d8589d. Read the comment docs.

@cmark cmark merged commit 530449a into 8.x Apr 13, 2022
@cmark cmark deleted the issue/SO-5406-freeze-retired-resources branch April 13, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants