perf(ui): ui twick & update theme-related config #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have just been diagnosed with COVID-19 and need to rest for a few days. |
Jint-lzxy
requested changes
Dec 24, 2022
There was a problem hiding this comment.
IMO I will accept the changes for wilder. However, for indent-blankline and virtualtexts, they are intentionally not background highlighted as this would affect performance when too many such objects are rendered in the same screenview (for example, scrolling quickly will cause deferred rendering).
nvimdots/lua/modules/ui/config.lua
Lines 251 to 255 in 708c1db
|
@Jint-lzxy fair enough, will remove those part. |
|
@ayamir take care! |
|
@Jint-lzxy PTAL. |
Jint-lzxy
approved these changes
Dec 24, 2022
vkingw
pushed a commit
to vkingw/nvimdots
that referenced
this pull request
Feb 7, 2023
* perf(ui): ui twick * revert virtual text bg highlisht * use it without wrapper function * revert indent-blankline & use it without wrapper function * remove wrapper function
YanTree
pushed a commit
to YanTree/nvim
that referenced
this pull request
Apr 9, 2023
* perf(ui): ui twick * revert virtual text bg highlisht * use it without wrapper function * revert indent-blankline & use it without wrapper function * remove wrapper function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some nice visual effects based on current plugins.
wilderindent-blacnklinevirtual-text