Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otel,loki,bigquery: add headers() option to dest #192

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

alltilla
Copy link
Member

@alltilla alltilla commented Jul 5, 2024

Example config:

opentelemetry(
  ...
  headers(
    "organization" => "Axoflow"
    "stream-name" => "axo-stream"
  )
);

Copy link
Contributor

github-actions bot commented Jul 5, 2024

This Pull Request introduces config grammar changes

axoflow/f18641e31f1a2884b4a36c731e60cfc0d5bace62 -> alltilla/otel-dest-headers

--- a/destination
+++ b/destination

 axosyslog-otlp(
+    headers(
+        <empty>
+        <string> => <string>
+    )
 )

 bigquery(
+    headers(
+        <empty>
+        <string> => <string>
+    )
 )

 loki(
+    headers(
+        <empty>
+        <string> => <string>
+    )
 )

 opentelemetry(
+    headers(
+        <empty>
+        <string> => <string>
+    )
 )

 syslog-ng-otlp(
+    headers(
+        <empty>
+        <string> => <string>
+    )
 )

Example config:
```
opentelemetry(
  ...
  headers(
    "organization" => "Axoflow"
    "stream-name" => "axo-stream"
  )
);
```

Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
@bazsi
Copy link
Member

bazsi commented Jul 7, 2024

I tested the headers() option for Otel as I had a good enough test environment locally and it seems to work fine. It did lowercase the header as expected and the tcpdump capture did contain the header added.

@MrAnno MrAnno merged commit ca64986 into axoflow:main Jul 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants