fix(lib): throttle ignored force
argument
#6438
Open
+2
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6417
On line 14 of
lib/helpers/throttle.js
,throttle
expectsthis
to betrue
when a call tofn
is enforced; however,this
would never equal totrue
/false
in non-strict mode asthis
cannot be a primitive. It instead is a wrapper object around the value in non-strict mode when it is called byFunction.prototype.call()
withthis
bound to any primitive value.This PR partially reverts d01386e by making
force
a parameter so it works both in strict and non-strict mode.