Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RoninGA] Emit event for tracking who voted #226

Merged
merged 3 commits into from
May 18, 2023
Merged

[RoninGA] Emit event for tracking who voted #226

merged 3 commits into from
May 18, 2023

Conversation

huyhuynh3103
Copy link
Contributor

@huyhuynh3103 huyhuynh3103 commented May 18, 2023 •
edited by nxqbao
Loading

Description

  • PSC-246 [GA][Contract] Emit event for who voted

Contract changes

The table below shows the following info:

  • Logic: the logic is changed.
  • ABI: the ABI is changed.
  • Init data: new storage field is declared and needs initializing.
  • Dependent: needs to be changed due to changes in other contracts.
Contract name Logic ABI Init data Dependent
RoninGovernanceAdmin x x

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@nxqbao nxqbao changed the title feat: emit event for tracking who voted [GA] Emit event for tracking who voted May 18, 2023
@nxqbao nxqbao changed the title [GA] Emit event for tracking who voted [RoninGA] Emit event for tracking who voted May 18, 2023
@nxqbao nxqbao changed the base branch from main to dev May 18, 2023 06:22
@nxqbao nxqbao merged commit d1f8cc8 into dev May 18, 2023
@nxqbao nxqbao deleted the psc-245/vote-tracking branch July 5, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nxqbao nxqbao nxqbao approved these changes

@ducthotran2010 ducthotran2010 Awaiting requested review from ducthotran2010

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huyhuynh3103 @nxqbao