Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added .dvmrc version lock support #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Chathula
Copy link

Story

This PR Incudes,

  • added .dvmrc file for deno version lock. this will automatically pick deno version from .dvmrc when run dvm use
  • updated the readme file with usage

@axetroy
Copy link
Owner

axetroy commented May 15, 2020

Thanks for your PR, but I do n’t think it ’s a good idea to add a .dvmrc

Keep it as simple as possible

@Chathula
Copy link
Author

Thanks for your PR, but I do n’t think it ’s a good idea to add a .dvmrc

Keep it as simple as possible

i think it is something important to have as nvm has it. this is something nodejs devs use daily to prevent from braking changes mainly. it will be important in the future when deno releases more breaking changes.

and most of the nodejs CIs use nvmrc when build the artifacts. deno will need it. just consider it again.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants