Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some legacy javaDoc examples in SqsMessageListenerContainer and SqsMessageListenerContainerFactory #1102

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

sefabal
Copy link
Contributor

@sefabal sefabal commented Mar 15, 2024

Javadoc examples are fixed

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

There were some legacy code examples in the Javadoc of SqsMessageListenerContainerFactory and SqsMessageListenerContainer classes that gave errors when we tried to apply them.
I tried to correct them with the existing implementations.

💡 Motivation and Context

I generally check Javadoc examples to apply library codes to my applications easily. This PR fixes some legacy code examples in the Javadoc.

💚 How did you test it?

It seems no test is required for the comment changes.

📝 Checklist

  • [ x] I reviewed the submitted code
  • I added tests to verify changes
  • [ x] I updated reference documentation to reflect the change
  • All tests passing
  • [ x] No breaking changes

🔮 Next steps

@github-actions github-actions bot added the component: sqs SQS integration related issue label Mar 15, 2024
Copy link
Contributor

@tomazfernandes tomazfernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution @sefabal , thanks!

Looking forward for more!

@tomazfernandes tomazfernandes merged commit 57c3d7d into awspring:main Mar 16, 2024
4 checks passed
maciejwalkowiak pushed a commit that referenced this pull request Mar 17, 2024
@maciejwalkowiak maciejwalkowiak added this to the 3.1.1 milestone Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: sqs SQS integration related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants