Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move child_process and events to llrt_modules #494

Merged
merged 18 commits into from
Jul 26, 2024

Conversation

Sytten
Copy link
Contributor

@Sytten Sytten commented Jul 23, 2024

Description of changes

  • Move child process and events modules to llrt_modules
  • Generalize the spawn_exit to allow users to not exit on error

Checklist

  • Created unit tests in tests/unit and/or in Rust for my feature if needed
  • Ran make fix to format JS and apply Clippy auto fixes
  • Made sure my code didn't add any additional warnings: make check
  • Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Sytten Sytten marked this pull request as ready for review July 25, 2024 22:12
Copy link
Contributor

@richarddavison richarddavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Only a small comment!

llrt_utils/src/ctx.rs Outdated Show resolved Hide resolved
@Sytten Sytten mentioned this pull request Jul 26, 2024
4 tasks
@richarddavison richarddavison merged commit ad0112a into awslabs:main Jul 26, 2024
8 checks passed
@Sytten Sytten deleted the ef-child-process branch July 26, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants