fix: throwing exceptions during module initialization #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richarddavison
requested changes
Jul 21, 2024
richarddavison
approved these changes
Jul 21, 2024
gc-victor
added a commit
to gc-victor/query
that referenced
this pull request
Jul 22, 2024
gc-victor
added a commit
to gc-victor/query
that referenced
this pull request
Jul 22, 2024
gc-victor
added a commit
to gc-victor/query
that referenced
this pull request
Jul 22, 2024
gc-victor
added a commit
to gc-victor/query
that referenced
this pull request
Jul 25, 2024
gc-victor
added a commit
to gc-victor/query
that referenced
this pull request
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if available)
Fixed #482
Description of changes
This PR will allow the correct output of the content of errors during module initialization.
After the revision:
% LLRT_NET_DENY=/ ./llrt -e 'console.log("123")' ReferenceError: LLRT_NET_DENY env contains an invalid URIChecklist
tests/unitand/or in Rust for my feature if neededmake fixto format JS and apply Clippy auto fixesmake checkBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.