Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analyzerOption to add filteredRowOutcome for isPrimaryKey Check #537

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

eycho-am
Copy link
Contributor

Issue #, if available:

Description of changes:
Follow-up PR to #532 and #535

  • Adding AnalyzerOptions to use FilteredRowOutcome for isPrimaryKey Check which uses the Uniqueness analyzer

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@rdsharma26 rdsharma26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Great job in keeping the Scala API backwards compatible.

@eycho-am eycho-am force-pushed the feature/rowLevelFilterPrimaryKey branch from 261bdce to 535684a Compare February 22, 2024 22:39
@eycho-am eycho-am merged commit 4070847 into awslabs:master Feb 23, 2024
1 check passed
@eycho-am eycho-am deleted the feature/rowLevelFilterPrimaryKey branch February 23, 2024 17:21
eycho-am added a commit that referenced this pull request Feb 23, 2024
…537)

* Add analyzerOption to add filteredRowOutcome for isPrimaryKey Check
* Add analyzerOption to add filteredRowOutcome for hasUniqueValueRatio Check
eycho-am added a commit that referenced this pull request Feb 23, 2024
…537)

* Add analyzerOption to add filteredRowOutcome for isPrimaryKey Check
* Add analyzerOption to add filteredRowOutcome for hasUniqueValueRatio Check
rdsharma26 pushed a commit that referenced this pull request Apr 16, 2024
…537)

* Add analyzerOption to add filteredRowOutcome for isPrimaryKey Check
* Add analyzerOption to add filteredRowOutcome for hasUniqueValueRatio Check
rdsharma26 pushed a commit that referenced this pull request Apr 16, 2024
…537)

* Add analyzerOption to add filteredRowOutcome for isPrimaryKey Check
* Add analyzerOption to add filteredRowOutcome for hasUniqueValueRatio Check
rdsharma26 pushed a commit that referenced this pull request Apr 16, 2024
…537)

* Add analyzerOption to add filteredRowOutcome for isPrimaryKey Check
* Add analyzerOption to add filteredRowOutcome for hasUniqueValueRatio Check
rdsharma26 pushed a commit that referenced this pull request Apr 17, 2024
…537)

* Add analyzerOption to add filteredRowOutcome for isPrimaryKey Check
* Add analyzerOption to add filteredRowOutcome for hasUniqueValueRatio Check
rdsharma26 pushed a commit that referenced this pull request Apr 17, 2024
…537)

* Add analyzerOption to add filteredRowOutcome for isPrimaryKey Check
* Add analyzerOption to add filteredRowOutcome for hasUniqueValueRatio Check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants