Improve handling of missing message attribute #59
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
src/test/java/com/amazonaws/services/sqs/AmazonSQSVirtualQueuesClientIT.java
Outdated
Show resolved
Hide resolved
| String queueName = message.getMessageAttributes().get(VIRTUAL_QUEUE_NAME_ATTRIBUTE).getStringValue(); | ||
| MessageAttributeValue messageAttributeValue = message.getMessageAttributes().get(VIRTUAL_QUEUE_NAME_ATTRIBUTE); | ||
| // Case where a message was sent with missing attribute __AmazonSQSVirtualQueuesClient.QueueName | ||
| if (messageAttributeValue == null) { |
There was a problem hiding this comment.
Can we add the virtualQueue null check here as well?
There was a problem hiding this comment.
We have a virtualQueue null check after this, since we need to use the messageAttributeValue to get the virtualQueue
| @@ -288,7 +288,13 @@ public HostQueue(String queueUrl) { | |||
| } | |||
|
|
|||
| private void dispatchMessage(Message message) { | |||
There was a problem hiding this comment.
I don't see a unit test for this change. Can we add one and make sure a mock orphanedMessageHandler is called if virtualQueue or messageAttributeValue is null?
There was a problem hiding this comment.
I added an check that orphanedMessageHandler is called
src/test/java/com/amazonaws/services/sqs/AmazonSQSVirtualQueuesClientIT.java
Show resolved
Hide resolved
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Description of changes:
Improve handling of missing message attribute on virtual queue receive and delete the message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.