Fix comparing milleseconds to seconds #45
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…rtbeats or its been more than 2X heartbeatIntervalSeconds
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| .addAttributesEntry(AmazonSQSIdleQueueDeletingClient.IDLE_QUEUE_RETENTION_PERIOD, "60"); | ||
| queueUrl = client.createQueue(createQueueRequest).getQueueUrl(); | ||
|
|
||
| SendMessageRequest send_msg_request = new SendMessageRequest() |
There was a problem hiding this comment.
nit: Java doesn't tend to use snake_case for anything
There was a problem hiding this comment.
Sorry had taken that from the AWS SDK for Java documentation :)
| @@ -297,7 +297,7 @@ private void heartbeatToQueueIfNecessary(String queueUrl) { | |||
| QueueMetadata queueMetadata = queues.get(queueUrl); | |||
| if (queueMetadata != null) { | |||
| Long lastHeartbeat = queueMetadata.heartbeatTimestamp; | |||
| if (lastHeartbeat == null || (System.currentTimeMillis() - lastHeartbeat) > 2 * heartbeatIntervalSeconds) { | |||
| if (lastHeartbeat != null && (System.currentTimeMillis() - lastHeartbeat) < 2 * heartbeatIntervalSeconds * 1000) { | |||
There was a problem hiding this comment.
Let's actually take out the 2X factor: I don't see a good reason for it, and since this line was broken before anyway it's not going to break anyone.
| @@ -18,6 +19,9 @@ | |||
| import com.amazonaws.services.sqs.util.SQSMessageConsumer; | |||
| import com.amazonaws.services.sqs.util.SQSQueueUtils; | |||
|
|
|||
| import static com.amazonaws.services.sqs.AmazonSQSIdleQueueDeletingClient.LAST_HEARTBEAT_TIMESTAMP_TAG; | |||
There was a problem hiding this comment.
Don't bother with a static import for a single reference, I think it just introduces an extra step to understand where something is defined.
There was a problem hiding this comment.
Removed the static import
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #40
Description of changes:
Fix comparing milleseconds to seconds
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.