Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added buildspec file used by CodeBuild #43

Merged
merged 6 commits into from
Jun 25, 2020
Merged

Added buildspec file used by CodeBuild #43

merged 6 commits into from
Jun 25, 2020

Conversation

adam-aws
Copy link
Contributor

Issue #41

Description of changes:
Setup CI for github project

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@adam-aws adam-aws requested a review from robin-aws June 23, 2020 20:46
robin-aws
robin-aws reviewed Jun 23, 2020
View reviewed changes
Copy link
Contributor

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the attempts so far show as passing even through the permissions aren't right. Let's figure that out first before we fix the permissions.

Make sure you hook up the github-codebuild-logs serverless app to report the build logs: https://serverlessrepo.aws.amazon.com/applications/arn:aws:serverlessrepo:us-east-1:277187709615:applications~github-codebuild-logs

buildspec.yml Outdated
phases:
install:
runtime-versions:
java: corretto11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be corretto8 to make sure we can still build/run on Java 8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooked up to github-codebuild-logs, getting a SignatureDoesNotMatch error, but apparently according to this jlhood/github-codebuild-logs#15 the issue gets resolved by itself after a few days

buildspec.yml Outdated
Comment on lines 14 to 15
- echo Running unit tests
- mvn clean test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary since Travis is already running the unit tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unit tests

@adam-aws
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: Java-Temporary-Client-CI
  • Commit ID: 137d55a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@adam-aws
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: Java-Temporary-Client-CI
  • Commit ID: cc36650
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@adam-aws
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: Java-Temporary-Client-CI
  • Commit ID: cc36650
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sqs-awslabs-ci
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: Java-Temporary-Client-CI
  • Commit ID: cc36650
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sqs-awslabs-ci
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: Java-Temporary-Client-CI
  • Commit ID: cc36650
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sqs-awslabs-ci
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: Java-Temporary-Client-CI
  • Commit ID: cc36650
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sqs-awslabs-ci
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: Java-Temporary-Client-CI
  • Commit ID: 497ab62
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sqs-awslabs-ci
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: Java-Temporary-Client-CI
  • Commit ID: 6ca094f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sqs-awslabs-ci
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: Java-Temporary-Client-CI
  • Commit ID: eeac0ad
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

robin-aws
robin-aws approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for getting this set up!

@adam-aws adam-aws merged commit 536db00 into awslabs:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robin-aws robin-aws robin-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adam-aws @aws-sqs-awslabs-ci @robin-aws