Auto-boxing null Integer to long causing NPE #24
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4, NPE when short-polling a virtual queue
Description of changes:
Appears that the ReceiveMessageRequest.waitTimeSeconds is type Integer, so it will be null if not provided. The Completable future get timeout seconds is long type. So the NPE is a result of the auto-boxing of Integer to long which isn't clear as it's happening under the hood in the JVM.
Added check for null and removed implicit auto-boxing by calling longValue() method on Integer object.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.